Fix non-deterministic map matrix dimension bug that causes bad Decode().

andychu commented 8 years ago

bin/test.sh: Change to h=1 to trigger the bug more reliably
move validation of inputs to Decode(), instead of decode_dist.R, so we get it whenever we call Decode()
Check dimensions in CreateAssocStringMap, for a better error message
Require 'params' when calling ReadMapFile/LoadMapFile, so the bug can't happen in the first place
Log a message when entries are removed from the map

tkaitchuck commented 8 years ago

I made the change to ReadCountsFile in the tkaitchuck branch. Either add it here, or we can merge twice.

andychu commented 8 years ago

Oh I see what you mean, I already merged this to master yesterday, because it was getting in the way of actually fixing these bugs.

https://github.com/google/rappor/commit/44dcf81d57dfc8863ab25ee9bde0e1db8800c8a0

On Fri, Jan 8, 2016 at 4:18 PM, Tom Kaitchuck notifications@github.com wrote:

I made the change to ReadCountsFile in the tkaitchuck branch. Either add it here, or we can merge twice.

— Reply to this email directly or view it on GitHub https://github.com/google/rappor/pull/60#issuecomment-170165520.

google / rappor

Fix non-deterministic map matrix dimension bug that causes bad Decode(). #60