google / rappor

RAPPOR: Privacy-Preserving Reporting Algorithms
Apache License 2.0
859 stars 165 forks source link

Shell cleanup #70

Closed tkaitchuck closed 8 years ago

tkaitchuck commented 8 years ago

Reopening (closed due to cli error)

andychu commented 8 years ago

I don't agree about run.sh. You're making a lot of unrelated changes at once -- it would be better to have separate pull requests and then we can untangle the issues. And also squash some of these changes together. Don't delete things just because you haven't used them.

tkaitchuck commented 8 years ago

Done. See #74

tkaitchuck commented 8 years ago

I added the subdirectory and docs.sh

ilyamironov commented 8 years ago

There's an empty file in this branch: gh-pages/test. Drop it?

ilyamironov commented 8 years ago

The file readme.md constains an outdate directory structure (misses gh-pages/, pipeline/, files docs.sh, util.sh, contains run.sh).

tkaitchuck commented 8 years ago

Done and done.