google / react-schemaorg

Type-checked Schema.org JSON-LD for React
Apache License 2.0
487 stars 19 forks source link

change build target to es5 #17

Closed bfellows37 closed 4 years ago

bfellows37 commented 4 years ago

This package has trouble with Internet Explorer 11. The reason is that it uses 'class' syntax and TS will retain that syntax when compiling to ES2015. Compiled to ES5, it works with IE11.

I propose changing the build target to extend support to IE11.

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

bfellows37 commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Eyas commented 4 years ago

Thank you for this!

bfellows37 commented 4 years ago

@Eyas out of curiosity, what does your npm publish schedule look like? I notice there have been 3 PRs merged since it was last published.

Eyas commented 4 years ago

@bfellows37 There's no set schedule, but I just published 1.0.2

bfellows37 commented 4 years ago

I appreciate it, @Eyas makes my life a little simpler :)