google / reflectable.dart

Reflectable is a Dart library that allows programmers to eliminate certain usages of dynamic reflection by specialization of reflective code to an equivalent implementation using only static techniques. The use of dynamic reflection is constrained in order to ensure that the specialized code can be generated and will have a reasonable size.
https://pub.dev/packages/reflectable
BSD 3-Clause "New" or "Revised" License
381 stars 57 forks source link

sdk minimal version should be 2.17.0 #290

Closed gmpassos closed 2 years ago

gmpassos commented 2 years ago

This package is using analyzer: ^4.6.0

https://github.com/google/reflectable.dart/blob/e9bcf6c8b5063c049673f3c433629e98d5c8a475/reflectable/pubspec.yaml#L10

The minimal Dart SDK for the package analyzer is Dart 2.17

And this package is using: https://github.com/google/reflectable.dart/blob/e9bcf6c8b5063c049673f3c433629e98d5c8a475/reflectable/pubspec.yaml#L8

So this package sdk should be:

  sdk: '>=2.17.0 <3.0.0'
eernstg commented 2 years ago

It's actually not necessary to have the same language version in any given package as the newest language version that any directly or indirectly imported library uses. But nobody can use this package with a tool chain which is older than that newest language version anyway, so it makes sense to update. Done in https://github.com/google/reflectable.dart/pull/288.