google / rejoiner

Generates a unified GraphQL schema from gRPC microservices and other Protobuf sources
https://google.github.io/rejoiner/
Apache License 2.0
3.67k stars 143 forks source link

readme: code example and the description are provided to be the same #115

Open memojja opened 3 years ago

memojja commented 3 years ago

In the readme statement says todoService isn't a protobuf message, so it's provided by the Guice injector. but in the code, todoClient is given as a parameter instead of todoService. I just made sure that the correct parameter was used

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

memojja commented 3 years ago

@googlebot I signed it!