Converting field name to camel cases only if "_" exists in the name

dsborets commented 6 years ago

It's an issue with GRPC result type field name converting. All fields are converting using UNDERSCORE_TO_CAMEL.convert(fieldDescriptor.getName()) in ProtoToGql class even if the field name doesn't contains "_" so it's causing a couple of problems:

incorrect camel case transformation: 'someTestField' -> 'sometestfield'
incorrect value binding GRPC -> GraphQL, lowercased field is always null

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.