google / rejoiner

Generates a unified GraphQL schema from gRPC microservices and other Protobuf sources
https://google.github.io/rejoiner/
Apache License 2.0
3.67k stars 139 forks source link

Mark GraphQLList elements as GraphQLNonNull #45

Closed gurel closed 6 years ago

gurel commented 6 years ago

ImmutableList doesn't allow null values. Given this the schema by default for lists should be defined as Non-Nullable.

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 67


Totals Coverage Status
Change from base Build 61: 0.3%
Covered Lines: 798
Relevant Lines: 1921

💛 - Coveralls