Closed gurel closed 6 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
rejoiner/src/main/java/com/google/api/graphql/rejoiner/SchemaModule.java | 4 | 5 | 80.0% | ||
<!-- | Total: | 4 | 5 | 80.0% | --> |
Totals | |
---|---|
Change from base Build 79: | 0.2% |
Covered Lines: | 807 |
Relevant Lines: | 1930 |
Nice, thanks!
When method.invoke throws an InvocationTargetException the original exception is hidden in the cause of this exception. The SchemaModule then wraps that with another RuntimeException.
Because of these the correct error never reached the GraphQL Execution.
When gRPC service throws:
The messages below gets rendered on the error.
Before:
After:
I also added a test case to check whether GraphQLError is also handled correctly.