Breaking Changes for Version 0.1.0?

soltran commented 6 years ago

Trying to upgrade from 0.0.4 to 0.1.0, but running into issues.

None of the examples work with 0.1.0 for me either when I try to upgrade. While I am able to installDist, I get this error when I pull open localhost:8080:

<head>
<meta http-equiv="Content-Type" content="text/html;charset=ISO-8859-1"/>
<title>Error 500 </title>
</head>
<body>
<h2>HTTP ERROR: 500</h2>
<p>Problem accessing /graphql. Reason:
<pre>    java.lang.NoClassDefFoundError: com/google/api/graphql/execution/GuavaListenableFutureSupport$1</pre></p>
<hr /><a href="http://eclipse.org/jetty">Powered by Jetty:// 9.3.8.v20160314</a><hr/>
</body>
</html>

Plus I get this error in the logs:

java.lang.NoClassDefFoundError: graphql/execution/instrumentation/NoOpInstrumentation
    at java.lang.ClassLoader.defineClass1(Native Method)


java.lang.NoClassDefFoundError: com/google/api/graphql/execution/GuavaListenableFutureSupport$1```

Would appreciate if someone can help :)

siderakis commented 6 years ago

Taking a look now!

soltran commented 6 years ago

thank you @siderakis !

siderakis commented 6 years ago

I've updated the examples to use v0.1.0. I wasn't able to reproduce that error, but I did need to add this dependency 'net.javacrumbs.future-converter:future-converter-java8-guava:1.1.0' since it was removed from the framework.

https://github.com/google/rejoiner/commit/064e6395c286bcd7d9bc3edbabaa626c4d3cd922

soltran commented 6 years ago

That fixed it! Thanks!

google / rejoiner

Breaking Changes for Version 0.1.0? #50