googlebot
commented
5 years ago Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
coveralls
jaslong
siderakis
Bug was introduced in 6a9323c0c5a9c84e59fcf95f5df16c3e74c2469a. This commit aimed to convert underscore_case field names to camelCase. While the GraphQLInputObjectField's name was converted, GqlInputConverter#createProtoBuf(), which converts Map<String, Object> to a protobuf Message, did not do the same conversion. This resulted in fields like "id" working, but fields like "user_id" being ignored.
This change fixes the bug and adds an assertion that all input fields were consumed.