google / rejoiner

Generates a unified GraphQL schema from gRPC microservices and other Protobuf sources
https://google.github.io/rejoiner/
Apache License 2.0
3.67k stars 139 forks source link

Add: support protobuf enum as args #78

Closed richard1122 closed 5 years ago

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

richard1122 commented 5 years ago

I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 310


Files with Coverage Reduction New Missed Lines %
rejoiner/src/main/java/com/google/api/graphql/rejoiner/SchemaDefinitionReader.java 1 85.0%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 305: 0.9%
Covered Lines: 919
Relevant Lines: 2066

💛 - Coveralls
sheepdreamofandroids commented 5 years ago

Looks good to me! Please merge, I'm running into the same problem.