google / rejoiner

Generates a unified GraphQL schema from gRPC microservices and other Protobuf sources
https://google.github.io/rejoiner/
Apache License 2.0
3.67k stars 143 forks source link

errors #93

Open luziyuan002 opened 4 years ago

luziyuan002 commented 4 years ago

Rejoiner's errors make me feel inconvenient because I can't define valid data to let the front desk staff know what the current error is, what kind of error is, because the current valid information is only message, which is not good judgment, I hope in When you execute responseObserver.onError(), you can have some properties in the error message, you can customize it, and let the background personnel return their own defined errors.

LIU0472 commented 4 years ago

https://github.com/google/rejoiner/blob/96fbb95342da08eb1b399f43fbf9c13a8abc0268/rejoiner/src/test/java/com/google/api/graphql/rejoiner/RejoinerIntegrationTest.java#L56-L78

https://github.com/google/rejoiner/blob/96fbb95342da08eb1b399f43fbf9c13a8abc0268/rejoiner/src/test/java/com/google/api/graphql/rejoiner/RejoinerIntegrationTest.java#L137-L141

@luziyuan002

luziyuan002 commented 4 years ago

https://github.com/google/rejoiner/blob/96fbb95342da08eb1b399f43fbf9c13a8abc0268/rejoiner/src/test/java/com/google/api/graphql/rejoiner/RejoinerIntegrationTest.java#L56-L78

https://github.com/google/rejoiner/blob/96fbb95342da08eb1b399f43fbf9c13a8abc0268/rejoiner/src/test/java/com/google/api/graphql/rejoiner/RejoinerIntegrationTest.java#L137-L141

@luziyuan002

Thank you, I think I know what to do.