search

google / restor

Restor is a user-friendly application to (mass) image macOS computers from a single source
Apache License 2.0
228 stars 29 forks source link

Build issue due to bazel changes #67

Closed arubdesu closed 5 years ago

arubdesu commented 5 years ago

As reported in Slack #restor, I was building from source and hitting errors that seem to have been introduced recently in bazel, https://github.com/bazelbuild/bazel/issues/7594

ERROR: /Users/allister/Documents/restor-master/Restor/BUILD:45:22: in asset_catalogs attribute of objc_library rule //Restor:restor_lib: objc_library resource attributes are not allowed. Please use the 'data' attribute instead.
ERROR: Analysis of target '//Restor:Restor' failed; build aborted: Analysis of target '//Restor:restor_lib' failed; build aborted
INFO: Elapsed time: 65.470s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (38 packages loaded, 654 targets configured)

I was able to figure out through the naming of the feature flip that the additional build flag I could use in the meantime is --incompatible_disable_objc_library_resources=false I tried to manually fix it in the BUILD file and it seemed to work for assets but not storyboards, if it had done fixed it you know me brudda, I'dve sent the PR 😉

russellhancox commented 5 years ago

Thanks for fixing this (#68)!