google / restor

Restor is a user-friendly application to (mass) image macOS computers from a single source
Apache License 2.0
228 stars 29 forks source link

Clicking image while still unlocking disk results in error #69

Open rcchan opened 5 years ago

rcchan commented 5 years ago

The disk unlock password prompt doesn't appear to prevent the user from clicking "Image" prematurely. Between entering the password and the time the disk is fully unlocked (password prompt still visible) user can click on "Image" which will throw the following error:

ASR failed with exit code: 1.
Potential Errors:
Couldn't set up partitions on target device - operation DeleteAPFSVolume, line #4518 - error 49165
Couldn't set up partitions on target device - operation DeleteAPFSVolume, line #4518 - error 49165
Couldn't set up partitions on target device - operation DeleteAPFSVolume, line #4518 - error 49165
Couldn't set up partitions on target device - operation DeleteAPFSVolume, line #4518 - error 49165
Couldn't set up partitions on target device - operation DeleteAPFSVolume, line #4518 - error 49165

While the error is expected, recovering from the error is difficult as you cannot re-select a disk that has errored out

rcchan commented 5 years ago

Image button should be disabled while unlocking disk