search

google / riegeli

Riegeli/records is a file format for storing a sequence of string records, typically serialized protocol buffers.
Apache License 2.0
418 stars 53 forks source link

chore(bazel): add MODULE.bazel files for bzlmod #30

Closed mmorel-35 closed 4 months ago

mmorel-35 commented 6 months ago

This follows #28

There is no workflow to validate online ?

Have you considered using github action or even buildkite?

This is partial as I'm waiting for https://github.com/bazelbuild/bazel-central-registry/pull/1833 to be merged to add boringssl

I have modify certain BUILD file so the target are aligned with the one used in there repsective Module

mering commented 5 months ago

@mmorel-35 Thanks for your PR!

In 15923d86939bf95cd0530bfa57cc4bbfcb61f444 we made the third party dependencies compatible with those on BCR based on this PR.

We are currently working towards adding a MODULE.bazel file.

mmorel-35 commented 5 months ago

You can have a partial module support. In the BCR only a part of the bazel target are supported. Otherwise it would have required to migrate tensorflow to bzlmod first which is a lot of work

mering commented 4 months ago

This should also add hermetic Python support to Bzlmod.

mering commented 4 months ago

Upload to BCR in https://github.com/bazelbuild/bazel-central-registry/pull/2186.