search

google / riegeli

Riegeli/records is a file format for storing a sequence of string records, typically serialized protocol buffers.
Apache License 2.0
418 stars 53 forks source link

Riegeli is incompatible with --incompatible_load_proto_rules_from_bzl #6

Closed shahms closed 4 years ago

shahms commented 4 years ago

This should be pretty straightfoward to fix, quoting from https://github.com/kythe/kythe/issues/4264 -- the bug Bazel filed against us (Kythe):

The Bazel team is in progress of migrating the native Protobuf rules to Starlark. As a first step towards this goal, starting with Bazel 3.0, all Protobuf rules will require explicit load statements.

You can use the following buildifier command to apply most of the required migrations for you:

buildifier --lint=fix --warnings=native-proto $(find . -name "BUILD" -o -name "BUILD.bazel" -o -name "*.bzl") For further information, see bazelbuild/bazel#8922 or ping me.

QrczakMK commented 4 years ago

Thank you. I am working on this.