search

google / robotstxt

The repository contains Google's robots.txt parser and matcher as a C++ library (compliant to C++11).
Apache License 2.0
3.39k stars 232 forks source link

googletest changed from master to main as their #50

Closed fabiomcosta closed 2 years ago

fabiomcosta commented 2 years ago

https://github.com/google/googletest doesn't have a "master" branch and fails when trying to compile with cmake. This change fixes that issue.

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

garyillyes commented 2 years ago

Thanks for bringing this up! I made the change on our side since the CLA was not signed: https://github.com/google/robotstxt/commit/86951c1bef42c99e84f4efc9eb6e799dac61c42c

fabiomcosta commented 2 years ago

Thank you!

On Thu, 16 Jun 2022 at 02:36 Gary Illyes @.***> wrote:

Closed #50 https://github.com/google/robotstxt/pull/50.

— Reply to this email directly, view it on GitHub https://github.com/google/robotstxt/pull/50#event-6819544975, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAG64RJKRV7QE6ME7UATA3VPLYRFANCNFSM5WGLW77Q . You are receiving this because you authored the thread.Message ID: @.***>

--

Fabio Miranda Costa (he/him/his) twitter: @fabiomiranda https://twitter.com/fabiomiranda github: fabiomcosta https://github.com/fabiomcosta/ linkedin: fabiomirandacosta https://www.linkedin.com/in/fabiomirandacosta/