search

google / rpmpack

rpmpack (tar2rpm) - package rpms in pure golang or cli
Apache License 2.0
116 stars 32 forks source link

fix sense bitmask #32

Closed rbtr closed 5 years ago

rbtr commented 5 years ago

closes https://github.com/google/rpmpack/issues/31

rbtr commented 5 years ago

nudge @jarondl @djgilcrease

rbtr commented 5 years ago

@jarondl understandable, it took me several reads of these bitshifts and the ones in the rpm source to actually notice they were different :smile: just added the decimal for all the values in the comments to make it very clear

rbtr commented 5 years ago

fwiw the CLI is signed and has been reporting OK until the latest push :thinking:

jarondl commented 5 years ago

Thank you very much for your contribution!

rbtr commented 5 years ago

@jarondl if this is good to go can we get a merge/tag so that nfpm and goreleaser can update their usages? thanks!

jarondl commented 5 years ago

\

fwiw the CLI is signed and has been reporting OK until the latest push thinking

I don't know what's up with the CLA assistant, or how to force it to check the status again.. I cannot merge without it. I'll check tomorrow.

rbtr commented 5 years ago

@jarondl force-pushed to trigger the webhooks and CLA caught on :)

jarondl commented 5 years ago

@jarondl if this is good to go can we get a merge/tag so that nfpm and goreleaser can update their usages? thanks!

done v0.3

rbtr commented 5 years ago

thanks!