search

google / rpmpack

rpmpack (tar2rpm) - package rpms in pure golang or cli
Apache License 2.0
116 stars 32 forks source link

feat: zstd compression and compressor levels #68

Closed erikgeiser closed 2 years ago

erikgeiser commented 2 years ago

This PR closes #66 by adding support for zstd compression. It also allows users to optionally specify the compression level for gzip (gzip:-2 up to gzip:9) and zstd (zstd:default, zstd:fastest, zstd:better, zstd:best, zstd:17). It also contains a test for the compression configuration.

I can also add bzip2 such that this PR can supersede #67 if you want.

erikgeiser commented 2 years ago

Thanks for your review. I fixed the issues. Should I also add bzip2 support such that this PR can supersede #67?

jarondl commented 2 years ago

/gcbrun

erikgeiser commented 2 years ago

I took a look at bzip2 but I found that the library used in #67 seems like a stale repository where all commits are from 2015 and 2016 and no issue was ever closed. I also did not found a better library. I don't really want to take the responsibility of adding this stale dependency to this project.

Thank you for merging this PR, though!