Closed Felixoid closed 2 years ago
The CLA is signed
Dear @jarondl, can you please, review it?
/gcbrun
The code looks maintained, the license is fine (MIT). I did not know people use such big files here.
Yeah looks fine, let's see if the tests pass.
You seem to be missing some changes in deps.bzl
, which will break bazel users. The tests inside example_bazel
fail.
Thank you. Sorry, I was a bit distracted the last week. I'll add it in a second
/gcbrun
What is the current issue? I don't have permissions in the cloud to see
> bazel build rpmpack
INFO: Analyzed target //:rpmpack (70 packages loaded, 7509 targets configured).
INFO: Found 1 target...
Target //:rpmpack up-to-date:
bazel-bin/rpmpack.a
INFO: Elapsed time: 1,872s, Critical Path: 1,17s
INFO: 19 processes: 2 internal, 17 linux-sandbox.
INFO: Build completed successfully, 19 total actions
Looks good now
/gcbrun
@Felixoid Thank you for the contribution, and for fixing build problems you cannot even see! (Yes it is messed up that you cannot see the build failure, I am gonna fix that).
Thank you for you patience.
This simple replacement gives a huge performance improvement. It's on my 11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz, 8 cores, 16 threads:
See attached file for details pkg.tgz.txt
For the default compression level it's significant too: