search

google / rune

Rune is a programming language developed to test ideas for improving security and efficiency.
Apache License 2.0
1.91k stars 46 forks source link

fix error compiling test/basecaselast.rn #17

Closed HAYASAKA-Ryosuke closed 1 year ago

HAYASAKA-Ryosuke commented 1 year ago

The test failed when runtests.sh is executed.

I fixed it by referring to here. https://github.com/google/rune/blob/main/doc/rune4python.md#recursion

The following PR was withdrawn because it had two commit logs. https://github.com/google/rune/pull/16

waywardgeek commented 1 year ago

Thanks for the fix, but this test is actually a test for the new "event driven" type infrencing code. This is a major rewrite of type binding, enabled with the -X flag, and the new code can bind basecaselast.rn. I won't get to it until maybe late December, or sometime in Q1 next year, but I'm upgrading the type binding system use unification-based type infrencing. It will be a slow transition, as there is a lot of code to write.

waywardgeek commented 1 year ago

Let's leave basecaselast.rn in a failing state for now.

HAYASAKA-Ryosuke commented 1 year ago

I understand. Thanks for the code review.