google / rust_icu

rust_icu: rust bindings for ICU (International Components for Unicode) library

Apache License 2.0

117 stars 28 forks source link

Make `simple_drop_impl!` hygienic #252

Closed SabrinaJewson closed 2 years ago

SabrinaJewson commented 2 years ago

Small PR that builds on #251 to make simple_drop_impl! hygienic as well. Only see the last commit, the rest are included in #251.

filmil commented 2 years ago

This needs a conflict resolution. I guess this is due to the out-of-sequence merge. I'll leave it to you to figure out the ordering in which you want them reviewed. Let me know which one is next.

SabrinaJewson commented 2 years ago

251 should be reviewed first, as its commits are a subset of this one’s.

filmil commented 2 years ago

https://github.com/google/rust_icu/pull/251 is merged - feel free to proceed here when able.

SabrinaJewson commented 2 years ago

Alright, rebased on main. Should be all good now.