Closed clydegerber closed 1 year ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
Your new tests are failing likely because the old ICU data does not have all the locale information present in more modern ICU versions, causing different results.
You may want to add a config flag on the value of icu_version_67_plus
on the affected tests, causing them to be skipped when compiled with ICU v63.
(In general I recommend depending less on the exact text in the ICU data responses as ICU data tends to change frequently. But I admit this is something I did early on too.)
Merged. Thank you for your contribution!
… version isn't found and add implementations for ICU functions: