fix: Improve the accuracy of the coverage report.

google / rust_icu

rust_icu: rust bindings for ICU (International Components for Unicode) library

Apache License 2.0

113 stars 34 forks source link

fix: Improve the accuracy of the coverage report. #296

Closed clydegerber closed 10 months ago

clydegerber commented 10 months ago

Ignore trailing '()' characters in function names when reporting coverage.
Only track functions that match a function in the header file of interest as implemented.
Mark the uenum::uloc_open_keywords as deprecated, copy the implementation into the uloc crate and copy the test that was in the uloc crate into the uenum crate so that it is still protected by a test even though deprecated.

filmil commented 10 months ago

Is it possible to use the canonical git commit messages, with a short one-line summary, and a slightly longer synopsis?

E.g. like https://www.conventionalcommits.org/en/v1.0.0/#summary - though I'm not a stickler to the specific format.

clydegerber commented 10 months ago

Is it possible to use the canonical git commit messages, with a short one-line summary, and a slightly longer synopsis?

E.g. like https://www.conventionalcommits.org/en/v1.0.0/#summary - though I'm not a stickler to the specific format.

Can do!