google / ruy

Apache License 2.0
303 stars 83 forks source link

Most callers directly depend on :cpuinfo, whose symbols are provided by :cpuinfo_impl, where linkstatic is set. When building tests (default to dynamic linking) with toolchains that set -fvisibility=hidden towards a static link to reduce code size, this would hide symbols and fail. This CL merges :cpuinfo, putting the symbols in the same build unit and solving this issue. #326

Closed copybara-service[bot] closed 1 year ago

copybara-service[bot] commented 1 year ago

Most callers directly depend on :cpuinfo, whose symbols are provided by :cpuinfo_impl, where linkstatic is set. When building tests (default to dynamic linking) with toolchains that set -fvisibility=hidden towards a static link to reduce code size, this would hide symbols and fail. This CL merges :cpuinfo, putting the symbols in the same build unit and solving this issue.

-std=gnu99 is removed as it's not required to build this package. This allows the headers to build standalone, so textual_headers no longer need to be specified.

:cpuinfo_mock now directly depends on :cpuinfo, so non-mock srcs are no longer needed and are removed from the target.

A typo in a macro is fixed alongside.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.