search

google / ruy

Apache License 2.0
303 stars 83 forks source link

Reapply IWYU fix for std::string usage in instrumentation.h #354

Open jdapena opened 7 months ago

jdapena commented 7 months ago

The fix applied by Stephan Hartmann adding the missing include for std::string usage in libruy has been removed again after syncing again with the copybara service.

Bug: chromium:41455655

jdapena commented 7 months ago

Not sure if this is waiting for me to merge. But I don't have such permissions for this repository.

talumbau commented 7 months ago

I believe the bot system is working correctly. Getting the appropriate internal approvals and I hope to see if the bot can complete the action today.

jdapena commented 6 months ago

@talumbau any update on this? This has not been applied yet.

jdapena commented 4 months ago

I am not sure what is happening, but apparently the copybara change is still not landed after the parallel pull request including this change.

jdapena commented 3 weeks ago

This is still not landed. I see copybara... has tested it?, but it is not landed to master (nor is the DEPS updated in chromium).