google / s2-geometry-library-java

Automatically exported from code.google.com/p/s2-geometry-library-java
Apache License 2.0
533 stars 230 forks source link

S2CellUnionTests Line 258-260 should be removed. #1

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
Line 258-260 as below should be removed:

            if (!u.contains(xId)) {
              u.getIntersection(xCells, yId);
            }

It is extraneous and guarantees the subsequent assertTrue(u.contains(xId)); on 
line 261 will always work even though this is the line that is being ultimately 
tested.

Original issue reported on code.google.com by uvico...@gmail.com on 9 Jul 2013 at 1:39