search

google / s2-geometry-library-java

Automatically exported from code.google.com/p/s2-geometry-library-java
Apache License 2.0
533 stars 230 forks source link

Mirror 9 years of internal changes outward. #21

Closed cpovirk closed 3 years ago

mwilli20 commented 4 years ago

@cpovirk Any hold up to merging this? This seems like a pretty nice thing to get on master.

cpovirk commented 4 years ago

Hi,

There have been a few things I'm working through with the actual owners of the library. We're making progress, but we're not quite there yet.

mwilli20 commented 4 years ago

Hi,

There have been a few things I'm working through with the actual owners of the library. We're making progress, but we're not quite there yet.

cool cool, just wanted to make sure this didn't fade away.

jeffreypicard commented 4 years ago

I would also very much like to see this merged. I'm using S2 heavily day-to-day and am currently building a lot of stuff like polygon indexes from scratch and I think the updates in here could be helpful, especially the addition of serializability since I do a lot of work in spark and have already written a bunch of kryo serializers, but I can't implement a proper partitioner in spark without them being serializable. I've hacked around that for the time being but want to wait for this update before throwing them into production.

Also might be worth noting to get this to build I needed an updated guava jar and the error_prone_annotations jar, neither of which are in the lib folder, the guava version being too old and the error_prone_annotations being non-existent.

animesh-sharama commented 4 years ago

Interested in seeing this getting merged, till the time will play with the cpovirk:moesync fork.

AlbertWigmore commented 3 years ago

Are there any updates regarding this PR?

aababilov commented 3 years ago

I would also very much like to see this merged. This is important for https://github.com/MobilityData/gtfs-validator used at Google.

aababilov commented 3 years ago

That is awesome, thanks a lot!

How can we also update the Maven repository to provide the newer library version? Here I see that the latest 1.0.1 version was created in 2019: https://mvnrepository.com/artifact/io.sgr/s2-geometry-library-java

cpovirk commented 3 years ago

We have several threads going about what to do about a binary release. Most of them are on Google-internal mailing lists, so I'll give the summary here:

io.sgr:s2-geometry-library-java is a copy of the library published by some other people under the same Java package but a different Maven ID.

The official artifact was com.google.common.geometry:s2-geometry. That disappeared when Bintray (an alternative to Maven Central) shut down.

It sounds likely that we'll publish version 1.0 of com.google.common.geometry:s2-geometry again, this time on Maven Central. Ideally we'll also follow that with a 2.0. But I don't want to commit anyone else to that work right now, nor can I commit to it personally.