google / s2-geometry-library-java

Automatically exported from code.google.com/p/s2-geometry-library-java
Apache License 2.0
533 stars 230 forks source link

Add OSGi metadata to the S2 geometry library #28

Closed timothyjward closed 2 years ago

timothyjward commented 3 years ago

In order to use this library in an OSGi framework it needs to include OSGi metadata. Rather than users having to repackage the code, it would be easier if the library jar already contained OSGi bundle metadata.

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

timothyjward commented 3 years ago

Rebased to fix the merge issue

eengle commented 3 years ago

Can you address the CLA issue?

On Wed, Aug 11, 2021 at 8:43 AM Tim Ward @.***> wrote:

Rebased to fix the merge issue

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/google/s2-geometry-library-java/pull/28#issuecomment-896936376, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4DAANALCSGNRZRDVR4PM3T4KLBTANCNFSM5BD3H4KQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

timothyjward commented 3 years ago

@googlebot I signed it!

timothyjward commented 2 years ago

Can you address the CLA issue?

Is there anything further that you need me to do?

eengle commented 2 years ago

CLAs look good to me now. Sorry that took awhile.

timothyjward commented 2 years ago

Thanks for adding the jar plugin as well. Can you update the description?

I've added a more descriptive commit message

eengle commented 2 years ago

Thanks!