search

google / s2-geometry-library-java

Automatically exported from code.google.com/p/s2-geometry-library-java
Apache License 2.0
533 stars 230 forks source link

Latest version in maven repo? #40

Open mrockban opened 1 year ago

mrockban commented 1 year ago

Can you please publish the latest version (with 2022 Q4 updates) to maven repo?

eengle commented 1 year ago

Which Maven repo are you using?

On Thu, Feb 16, 2023 at 6:19 AM Michal Rockban @.***> wrote:

Can you please publish the latest version (with 2022 Q4 updates) to maven repo?

— Reply to this email directly, view it on GitHub https://github.com/google/s2-geometry-library-java/issues/40, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4DAAP6UZWRP5UQCT5GW53WXYZQHANCNFSM6AAAAAAU6HQUL4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

mrockban commented 1 year ago

Which Maven repo are you using? … On Thu, Feb 16, 2023 at 6:19 AM Michal Rockban @.> wrote: Can you please publish the latest version (with 2022 Q4 updates) to maven repo? — Reply to this email directly, view it on GitHub <#40>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4DAAP6UZWRP5UQCT5GW53WXYZQHANCNFSM6AAAAAAU6HQUL4 . You are receiving this because you are subscribed to this thread.Message ID: @.>

I'm using this one: https://mvnrepository.com/artifact/com.google.geometry/s2-geometry (central repo)

mattb314 commented 1 year ago

We're also consuming from maven central (same as @mrockban) and would love to be able to pull the latest updates from a release there.

FabianAhammer commented 1 year ago

Would also appreciate an update to the library on maven central, as it already seems to be more current than the package

TorreyHoffman commented 1 year ago

I'm sorry I haven't updated the Maven repository. I plan to make another update to the open source library later this year, and I intend to update the Maven repository then - and keep it up to date after that, going forward.

Torrey

On Thu, Aug 17, 2023, at 11:09 PM, Fabian Ahammer wrote:

Would also appreciate an update to the library on maven central, as it already seems to be more current than the package

— Reply to this email directly, view it on GitHub https://github.com/google/s2-geometry-library-java/issues/40#issuecomment-1683401858, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABT3JGY7HDNQ2NJJLZO47PLXV4BLNANCNFSM6AAAAAAU6HQUL4. You are receiving this because you are subscribed to this thread.Message ID: @.***>

chrismgrayftsinc commented 7 months ago

@TorreyHoffman friendly ping. I'd also love to get the latest updates.

TorreyHoffman commented 7 months ago

I'm sorry the Maven repo update hasn't happened yet. It isn't forgotten but frankly it isn't a very high priority right now. We just got re-orged and there's a lot of urgent things to do and work in progress for internal users, and as you'd expect that's our top priority.

It seems like a Maven update should be an easy thing to do, but the Maven repo was set up by another person who's since moved on and the password has been lost...

On a brighter note, I think a new update with S2Builder ported from C++ will make it out to GitHub soon, as I have an established workflow for that.

Torrey

On Tue, Feb 6, 2024, at 11:24 AM, Chris Gray wrote:

@TorreyHoffman https://github.com/TorreyHoffman friendly ping. I'd also love to get the latest updates.

— Reply to this email directly, view it on GitHub https://github.com/google/s2-geometry-library-java/issues/40#issuecomment-1930608802, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABT3JG627AITUPEHBEDANT3YSJ7PZAVCNFSM6AAAAAAU6HQUL6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZQGYYDQOBQGI. You are receiving this because you were mentioned.Message ID: @.***>

timothyjward commented 4 months ago

It seems like a Maven update should be an easy thing to do, but the Maven repo was set up by another person who's since moved on and the password has been lost...

If Maven Central is difficult then would it be possible to publish/release to GitHub packages instead?

mvn -DaltDeploymentRepository=github::https://maven.pkg.github.com/google/s2-geometry-library-java deploy

It's pretty easy with GitHub Actions too:

run: mvn --batch-mode -DaltDeploymentRepository=github::https://maven.pkg.github.com/${{ github.repository }} deploy
  env:
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

If GitHub packages is an acceptable option (at least in the interim) then I would be happy to put together an action in a pull request if it would help.

ericangle commented 4 months ago

I created a google group conversation before realizing this github issue existed. In that conversation, Sean said:

It looks like Github has support for this: https://docs.github.com/en/actions/publishing-packages/publishing-java-packages-with-maven so if you put together a pull request to setup the workflow I imagine we'd accept it.