search

google / s2geometry

Computational geometry and spatial indexing on the sphere
http://s2geometry.io/
Apache License 2.0
2.29k stars 303 forks source link

GTEST_ROOT not optional! #234

Closed MBkkt closed 2 years ago

MBkkt commented 2 years ago

https://github.com/google/s2geometry/blob/master/src/s2/s2shapeutil_testing.cc#L20

This file is built regardless of the value of GTEST_ROOT

Btw why so inconvenient? Just add S2_BUILD_TESTS=ON/OFF and disable it by default

MBkkt commented 2 years ago

https://github.com/google/s2geometry/pull/170