search

google / s2geometry

Computational geometry and spatial indexing on the sphere
http://s2geometry.io/
Apache License 2.0
2.29k stars 302 forks source link

Expose more functionality via the SWIG wrapper #257

Closed MikePlayle closed 2 years ago

MikePlayle commented 2 years ago

Add S2::UpdateMinDistance, s2pred::OrderedCCW, S2::Interpolate, S2Polygon::InitToUnion, some more of S2::S1ChordAngle, and a method for retrieving the S2Point's underlying 3-vector.

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

MikePlayle commented 2 years ago

Extended to add S2BufferOperation, S2BooleanOperation and S2Builder, along with various things that they depend on.

I'm not sure that this is necessarily the "right way" to do it - if there are any problems here, now would be a good time to discuss them.

MikePlayle commented 2 years ago

Is there anything else I need to do to this pull request?

Would it help if I split it up?

jmr commented 2 years ago

Splitting it up would probably get you pieces sooner, if that's useful to you. Probably not worth the effort otherwise. I'll look more at this tomorrow.

jmr commented 2 years ago

Sorry for the delay, I'll merge after I understand https://github.com/google/s2geometry/pull/257/files#r953600009 .

jmr commented 2 years ago

Thanks!