search

google / s2geometry

Computational geometry and spatial indexing on the sphere
http://s2geometry.io/
Apache License 2.0
2.29k stars 302 forks source link

Fix RemoveLast #267

Closed MBkkt closed 2 years ago

jmr commented 2 years ago

I don't understand the problem; can you explain how it's broken?

MBkkt commented 2 years ago

unary minus operator applied to unsigned type, result still unsigned

I don't think it's desirable

jmr commented 2 years ago

It's not broken unless ptrdiff_t and size_t aren't the same size, but I agree it's clearer your way.