Closed MBkkt closed 1 year ago
Having 6 PRs in 1 will quickly become unwieldy. Please split up future PRs for easier disucssion.
Having 6 PRs in 1 will quickly become unwieldy. Please split up future PRs for easier disucssion.
Will be done
Yeah let's split this one up we can probably submit the others separate from the term indexer one.
@jmr @smcallis Hello, I created separate PRs (found asan issue and add tests for new option) can you look they?
Closing this since it's been split into #298, #299, #300, #301, #302, and #303.
Improve s2region_term_indexer:
Add access to coverer
Add access to S2Polygon::subregionbound
Add S2_SYSTEM_HEADERS cmake options to avoid s2 compile time warnings from s2 headers
Add S2_INSTALL option with keeping old behavior
Needs tests run! PR now mostly for discussion.