search

google / s2geometry

Computational geometry and spatial indexing on the sphere
http://s2geometry.io/
Apache License 2.0
2.29k stars 302 forks source link

Can there be a new release cut? #341

Closed jherico closed 7 months ago

jherico commented 7 months ago

I'm trying to get the vcpkg version of s2geometry updated so that it will build on windows, but the vcpkg maintainers don't want to accept an essentially random commit as a new build when this project already has a version history in vcpkg using tagged releases.

It seems like the google3 merge 9 months ago or anything subsequent to that would make a good spot for a version bump and a new build.

Thanks.

jmr commented 7 months ago

I'm working on integrating the latest Google changes, but tagging what we have sounds reasonable.

jmr commented 7 months ago

I merged #339. I'll let you update on your side and test it. Let me know if it's good to tag HEAD.

jherico commented 7 months ago

my branch of vcpkg now builds s2 successfully without any patches required, targeting the commit 5c2190ab374dcfa7467bd4894e4db6038e60a131. As soon as you tag it I can change the ref to the tag from the commit ID and update the vcpkg PR. Thanks.

jmr commented 7 months ago

https://github.com/google/s2geometry/releases/tag/v0.11.0