google / s2geometry

Computational geometry and spatial indexing on the sphere
http://s2geometry.io/
Apache License 2.0
2.29k stars 302 forks source link

Update to latest google3 version #360

Closed jmr closed 5 months ago

jmr commented 5 months ago
smcallis commented 5 months ago

Whooo thanks Jesse.

iljya commented 4 months ago

I believe that after this commit, the project no longer compiles with C++14. At least I got errors with this file: src/s2/util/gtl/requires.h

With C++17 it works. C++14 is claimed to be supported in a number of places, like the README and CMakeLists.txt. I'm not sure if this was intended and simply the documentation should be updated, or not intended.

jmr commented 4 months ago

That's a mistake. I'll make a new PR soon.