search

google / s2geometry

Computational geometry and spatial indexing on the sphere
http://s2geometry.io/
Apache License 2.0
2.29k stars 302 forks source link

A bazel build and regression harness for s2geometry #361

Open spendres opened 4 months ago

spendres commented 4 months ago

See issue #53.

This version relies on the bazel central repository for abseil-cpp, googletest, and boringssl and points to HEAD of s2geometry.

google-cla[bot] commented 4 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

spendres commented 4 months ago

...logging.h was removed in most recent commit/push.

spendres commented 3 months ago

I tested build times for a hierarchical library definition as compared to a single flat library definition for s2. The flat definition builds twice as fast (12 sec vs 25 sec) about 25% of the time – using a mac M1. This is counter to expectations, so I reverted to the flat definition.

spendres commented 3 months ago

Thanks for the requested changes by mmorel-35 … made and pushed.