google / safebrowsing

Safe Browsing API Go Client
Apache License 2.0
470 stars 129 forks source link

Added proxy support #76

Closed 3kt closed 6 years ago

3kt commented 6 years ago

A proxy can now be used by using the -proxy parameter in both sblookup and sbserver. This overrides the default use of the environment variable HTTP_PROXY (or http_proxy). Please refer to https://golang.org/pkg/net/http/#RoundTripper for more info

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


3kt commented 6 years ago

The CLA should have been handled. I'm contributing as part of a company, and was told that all the required steps have been completed. Could you please confirm?

colonelxc commented 6 years ago

Code looks good. There is a bit of an issue in verifying the CLA.

Once those are taken care of, the bots will be happy, and I'll merge it.

googlebot commented 6 years ago

CLAs look good, thanks!

colonelxc commented 6 years ago

Thanks again for the PR!