google / safeside

Understand and mitigate software-observable side-channels
BSD 3-Clause "New" or "Revised" License
498 stars 54 forks source link

Correct the LICENSE copyright statement. #11

Closed ssbr closed 5 years ago

ssbr commented 5 years ago

I guess none of us actually read boilerplate license files. Oops.

(I am surprised this wasn't caught as part of the Ariane approvals process actually; doesn't the bot check these? I've made a note to investigate and report a bug on Tuesday.)

https://opensource.google.com/docs/releasing/contributions/ talks about what exactly to put in the copyright statement. I see at least one commit in a fork (adding support for a new platform), which I am actually really looking forward to reviewing, so we may eventually want to replace "Google" here with "The SafeSide authors" or the like. But, for now, since all the files use Google LLC, this should too.

ssbr commented 5 years ago

Aha! I scanned for the license statement and didn't see that this was an appendix. I think I just failed at reading. This ain't like the MIT license where you're supposed to rewrite the first line.

mmdriley commented 5 years ago

The, er, varied approaches here across different projects are sort of funny:

Overall, I'm okay calling this a canonical reference: https://github.com/apache/httpd/blob/91fd63d927004e05a537bb64c2194674d65d6c10/LICENSE#L189