Fix MSVC warnings about redundant `inline`

google / safeside

Understand and mitigate software-observable side-channels

BSD 3-Clause "New" or "Revised" License

498 stars 54 forks source link

Fix MSVC warnings about redundant `inline` #117

Closed mmdriley closed 4 years ago

mmdriley commented 4 years ago

MSVC thinks __forceinline inline is redundant because __forceinline implies inline. The opposite isn't true, so we avoid the warning by reversing them on any declaration MSVC can see.

mmdriley commented 4 years ago

Here's the warning at master: https://travis-ci.org/google/safeside/jobs/654555961#L69

and here are the logs from this PR: https://travis-ci.org/google/safeside/jobs/654561622

mmdriley commented 4 years ago

I cribbed this approach from https://github.com/google/benchmark/pull/469