Rewrite meltdown_de and meltdown_of to use RunWithFaultHandler

google / safeside

Understand and mitigate software-observable side-channels

BSD 3-Clause "New" or "Revised" License

498 stars 54 forks source link

Rewrite meltdown_de and meltdown_of to use RunWithFaultHandler #130

Closed mmdriley closed 4 years ago

mmdriley commented 4 years ago

In the process, update RunWithFaultHandler to deal with different signals.

See individual commits for more detail.

mmdriley commented 4 years ago

Not sure if you've seen this -- it's sort of buried in the Github UI -- but for PRs like this with multiple commits you can view them one at a time and pretty easily switch between them.

Click any commit in the PR to go to it, then there are "Prev" and "Next" buttons at the top-right. Review comments work there too.

mmdriley commented 4 years ago

Comments should be addressed. Will squash PR feedback commits and merge tomorrow if all's well.

mmdriley commented 4 years ago

One notable change: I outlined the implementation of ExtendSpeculationWindow. It was originally inline because I thought it needed to be SAFESIDE_ALWAYS_INLINE, but that didn't turn out to be the case.