google / safeside

Understand and mitigate software-observable side-channels
BSD 3-Clause "New" or "Revised" License
498 stars 54 forks source link

Compiler specifics for operating systems. #79

Closed asteinha closed 5 years ago

asteinha commented 5 years ago

The code looks good. What's the rationale for adding a SAFESIDE_LINUX and SAFESIDE_MAC? I don't immediately see the benefit of that over checking __linux__ or __APPLE__ everywhere.

It's mostly just consistency with the way how we check for compilers and CPU architectures. Ask @mmdriley who initiated the migration. I don't have a strong opinion about this.