search

google / sagetv

SageTV is a cross-platform networked DVR and media management system
http://forums.sagetv.com/
Apache License 2.0
265 stars 174 forks source link

Additional Airings from Favorite Details shows is not restricted to "Title:xxx" Keyword #290

Open jerrymolenaar opened 7 years ago

jerrymolenaar commented 7 years ago

I upgraded to version 9.1.1.651. Everything seems to work except when I try to view Additional Airings from the Favorite Details for entries that are looking for a Keyword which is "Title:" and some value. In that scenario, it seems to be displaying the EPG because it starts with titles with a 100 in them and goes on and on.

Other Favorites which are not using Keywords seem to be working fine,

I rolled the JAR file back to 9.0.14.567 and it worked fine. Reinstalled 651 and problem re-occurred.

It does not seem to effect the schedule, that is showing as I expect.

Any other data I can provide?

Narflex commented 7 years ago

@enternoescape Can you look into this?

enternoescape commented 7 years ago

This API function pretty much uses followsTrend() directly does it not? I didn't fiddle with that very much, so I'm curious what actually broke.

enternoescape commented 7 years ago

Nevermind. It uses getRelatedAirings(). I'll see where we went wrong there.

enternoescape commented 7 years ago

I found it. On line 775 in Agent.java:

if (followsTrend(a, true, sbCache, true, ignoreDisabledFlag))

should be:

if (followsTrend(a, true, sbCache, false, ignoreDisabledFlag))

enternoescape commented 7 years ago

It's causing it to skip the keyword search completely. I'll submit a fix.

enternoescape commented 7 years ago

The getRelatedAirings() issue doesn't cause massive problems, but I can see it being annoying to some people until a new version is released with the fix. This issue did not affect scheduled recordings in any way, so I'm looking for an opinion on if we should publish a new version immediately. Maybe we should simmer for a week and not get too excited. I did verify the problem and I verified that the prescribed fix did fix it.

jerrymolenaar commented 7 years ago

Glad it was easy to find, I am ok with simmering.

enternoescape commented 7 years ago

You didn't exactly appear to be outraged. :) The changes in Carny were significant, but the code behind this didn't change in any significant way, so I was a little surprised to see this broke, but at least the fix was very straight forward.

enternoescape commented 7 years ago

I miss read your simmering comment. I read "I'm done with simmering."

jerrymolenaar commented 7 years ago

LOL, No, I am definitely not outraged - Happy to wait until the next release! I am very thankful for all of the hard work all of you guys put into SageTV!

CraziFuzzy commented 7 years ago

Was just about to come in and write an issue for this. Just added a new keyword only favorite for my daughter [Taekwondo] and was a little surprised to see 1008 future airings that had nothing to do with it.

enternoescape commented 7 years ago

As you probably noticed this doesn't affect the scheduled recordings, just what you see via the API calls. For the initial commit, we were so focused on making sure the scheduling was exactly the same that I failed to verify that one simple API call on a keyword favorite. We're going to wait a little bit before I ask for another build just in case something else of interest surfaces. This isn't quite an emergency, but it is important that it be addressed and the next build will fully address this one issue.

CraziFuzzy commented 7 years ago

Yeah, no problem. Just glad it's already been identified.