Narflex
commented
7 years ago This has no negative impact, we just never read a DTS when present in the bitstream for MPEG-1 (but we do properly skip over it if there).
On Thu, Jun 15, 2017 at 9:32 AM, appchecker notifications@github.com wrote:
Hi!
This expression https://github.com/google/sagetv/blob/f1f12ee3f4fcaf3f3b534f028f054b38ba00f8ee/java/sage/FastMpeg2Reader.java#L2123 ((b & 0xE0) == 0x30) is always false.
0xE0 = 0000 0000 1110 0000b ------------------------^ 0x30 = 0000 0000 0011 0000b ------------------------^ The fifth bit of expression (b & 0xE0) is 0 anyway.
This possible defect found by AppChecker https://npo-echelon.ru/en/solutions/appchecker.php.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/google/sagetv/issues/305, or mute the thread https://github.com/notifications/unsubscribe-auth/ANEIDC4s0mBUiroY9cnX_RbBMd_zhHGdks5sEVyUgaJpZM4N7dQS .
-- Jeffrey Kardatzke jkardatzke@google.com Google, Inc.
Hi!
This expression
((b & 0xE0) == 0x30)is always false.0xE0 = 0000 0000 1110 0000b ------------------------^
0x30 = 0000 0000 0011 0000b ------------------------^
The fifth bit of expression (b & 0xE0) is 0 anyway.
This possible defect found by AppChecker.