search

google / sagetv

SageTV is a cross-platform networked DVR and media management system
http://forums.sagetv.com/
Apache License 2.0
267 stars 173 forks source link

Add support for all 4 tuners of Hauppauge WinTV-quadHD board #320

Closed JustFred51 closed 7 years ago

JustFred51 commented 7 years ago

This commit resolves Issue # 318 (enhancement). Magic text to link to the feature-request Issue; closing this issue will also close that one, too:

fixes # 318

googlebot commented 7 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

JustFred51 commented 7 years ago

Added secondary email address to GitHub acct to resolve the CLA issue.

JustFred51 commented 7 years ago

The bot still seems to be unhappy about the CLA, even though my GitHub acct now includes a secondary email address (the one that's linked to my signed CLA). I had successfully committed some time ago, without any issues. Not sure what the problem is now.

JustFred51 commented 7 years ago

Let's see if this solves the problem: Added old email addr (used when GitHub desktop app was initially installed) to my GitHub acct online.

googlebot commented 7 years ago

CLAs look good, thanks!

Narflex commented 7 years ago

Nice...effectively a 2 line change to make this work. Thanks for doing all the digging to figure it out!

JustFred51 commented 7 years ago

Yeah, it took quite a bit of digging to make sense of the overall scheme of things. I tried to leave a few more comments and some debug tools for future contributors, as well as myself.

I'm not thrilled with how Visual Studio silently mucks with white-space for no apparent reason. Admittedly, the result is a bit more readable. But it comes at the expense of a larger # of lines to review for the pull-request and tends to obscure the "meat" of the actual fix. So it goes.

Another forum poster has offered a Hauppauge dualHD usb tuner to see if we can get Sage to recognize it's 2nd tuner, so I may be revisiting this section of the code again soon. Will open a separate issue for the dualHD if that materializes.

stuckless commented 7 years ago

just a fyi... when you are viewing a pull-request if you appent ?w=1 (or &w=1 if there are other parameters), then the compare will ignore whitespace changes.