search

google / sagetv

SageTV is a cross-platform networked DVR and media management system
http://forums.sagetv.com/
Apache License 2.0
267 stars 174 forks source link

Clean up of VS2015 warnings - Part 3 #431

Closed JREkiwi closed 4 years ago

JREkiwi commented 4 years ago

Changes from SageService Launcher applied to MiniClient Launcher Resolve Compile and Static Analysis warnings Change to MS safe/secure functions

JREkiwi commented 4 years ago

Looks like some of the indentation got screwed up

Narflex commented 4 years ago

And in the future...please limit your pull requests to much smaller changes. For stuff like this, ideally it'd be one file at a time (unless it's just a couple line change). It's too easy for me to start to glaze over when doing a review like this and miss something.

JREkiwi commented 4 years ago

And in the future...please limit your pull requests to much smaller changes. For stuff like this, ideally it'd be one file at a time (unless it's just a couple line change). It's too easy for me to start to glaze over when doing a review like this and miss something.

Yeah, sorry about that, and noted. I started out trying to just do the MiniClientLauncher with the changes that had been done for the ServiceControlLaunch and what I thought was going to be just a couple of lines in some other files, but then I got trapped in SageTVWin32DLL.cpp :)

JREkiwi commented 4 years ago

Apologies for all the back and forth and thanks once again for all the time you've spent walking me through this.

Narflex commented 4 years ago

No problem, thanks for the cleanups. :)