search

google / sagetv

SageTV is a cross-platform networked DVR and media management system
http://forums.sagetv.com/
Apache License 2.0
267 stars 173 forks source link

Added the ability to create a format detection plugin #433

Closed jvl711 closed 4 years ago

jvl711 commented 4 years ago

I added the ability to add your own format detection plugin ! added a new property to subtitles for forced subtitles I added a code to auto select a subtitle track if it is "forced" and in your default language Added the HEVC format Added the new format string for MKV that includes WEMB Added 4k resolution

googlebot commented 4 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

jvl711 commented 4 years ago

@Narflex

This is probably a stupid question, but what is the proper way to make these changes. Should I just make the changes and create a new pull request. Is there a way to update this pull request as I make my updates?

Thanks, Josh

Narflex commented 4 years ago

I haven't actually done pull requests like everybody else with GitHub before, so I don't have much advice I can offer. But there should be plenty of info out there on how to do it. :) I just check stuff directly into master myself without reviews...because that's what I've always done with SageTV code (but nobody else is allowed to do that).

jvl711 commented 4 years ago

@Narflex

I did some googling. I think I am going to create two branches. One for the FormatDetector plugin, and another for the forced subtitle changes, and resubmit two pull requests. Then when you ask for changes to the pull request I think I just update that branch associated with the pull request.

Can we hold onto this pull request until I submit the other two requests. I want to make sure I fix all of your comments.

I use SVN in my day job, so the git workflow is pretty new to me as well.