google / sagetv

SageTV is a cross-platform networked DVR and media management system
http://forums.sagetv.com/
Apache License 2.0
267 stars 173 forks source link

Add forced subtitle property to media file #435

Closed jvl711 closed 4 years ago

jvl711 commented 4 years ago

Added forced property to the subtitle tracks. Added code to auto select forced subtitle tracks that match the default audio language. Added the forced subtitle property to output in the API.

Also added netbeans project files to the .gitignore files.

jvl711 commented 4 years ago

@Narflex

I think I addressed everything except for:

Also, in the default subtitle selection code, you should update that to prefer the non-forced subs for the matching language in order to improve how that code works now that we know which are which.

I will look at that next. If you have a minute can you review what I have so far.

Thanks, Josh

jvl711 commented 4 years ago

@Narflex

Pushed another update. Let me know how it looks.

Josh

jvl711 commented 4 years ago

@Narflex

Fixed the logic mistake.

Josh

Narflex commented 4 years ago

I cleaned up a couple import statements myself, all looks good now. :)