search

google / sagetv

SageTV is a cross-platform networked DVR and media management system
http://forums.sagetv.com/
Apache License 2.0
267 stars 173 forks source link

Added option to FFMpegTranscoder to be able to copy audio or video without conversion (remux) #454

Closed jvl711 closed 3 years ago

jvl711 commented 3 years ago

This is the first of a few changes to allow for remuxing when the container format is not supported using the miniclient. I am going to add a property for a fixed remux format.

Let me know if you have any questions or concerns. High level testing has looked good. Submitting in smaller pieces.

Narflex commented 3 years ago

I'm curious why you did this rather than just leaving it the way it was and using "copy" for the codec name. This is really just adding the ability to use "COPY" as well as "copy" to achieve the result.

jvl711 commented 3 years ago

I did not want any of the other command line options being sent when copying . I assume it might work, but seems kinda ugly if you passed unused/unneeded . I have not tested it, FFMpeg may complain.

I am fine changing it if you prefer it designed different!

Narflex commented 3 years ago

I looked at this too soon after I woke up and didn't realize it was doing more than what I said. Ignore my initial comment. :) But do pay attention to the review comment, there's a couple args you need to move around. And the overall order can be changed, just be sure you keep the acodec/vcodec args before their related audio/video parameters.

Narflex commented 3 years ago

For some reason this didn't kick off a travis CI run...but it's good to merge.