Added some additional constraints on -aspect swith in FFMPEGTranscoder to make sure an invalid aspect ratio is not passed to the transcoder. In my testing, I saw a few occurrences when watching live TV where the content did not seem to be properly identified, and the container format had no aspect or dimensions to the video. This caused FFMPEGTranscoder to pass -aspect 0:0. This caused the transcoder to fail and Sage client to display a blank screen.
I realize this is a code path that should probably not occur, but I also think it is a reasonable check and restriction. I would rather FFmpeg try again to determine the aspect when it has more data.
jvl711
commented
3 years ago
Added some additional constraints on -aspect swith in FFMPEGTranscoder to make sure an invalid aspect ratio is not passed to the transcoder. In my testing, I saw a few occurrences when watching live TV where the content did not seem to be properly identified, and the container format had no aspect or dimensions to the video. This caused FFMPEGTranscoder to pass -aspect 0:0. This caused the transcoder to fail and Sage client to display a blank screen.
I realize this is a code path that should probably not occur, but I also think it is a reasonable check and restriction. I would rather FFmpeg try again to determine the aspect when it has more data.
Josh